]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
bnxt_en: Do not setup PHY unless driving a single PF.
authorMichael Chan <michael.chan@broadcom.com>
Mon, 13 Feb 2017 00:18:15 +0000 (19:18 -0500)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Feb 2017 03:18:49 +0000 (22:18 -0500)
If it is a VF or an NPAR function, the firmware call to setup the PHY
will fail.  Adding this check will prevent unnecessary firmware calls
to setup the PHY unless calling from the PF.  This will also eliminate
many unnecessary warning messages when the call from a VF or NPAR fails.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index f3d829f71f774df9ba4ebf84c1576e1310e90dfe..afd119097344b9526d6eef3a75cbc5f33bb70761 100644 (file)
@@ -5853,6 +5853,9 @@ static int bnxt_update_phy_setting(struct bnxt *bp)
                           rc);
                return rc;
        }
+       if (!BNXT_SINGLE_PF(bp))
+               return 0;
+
        if ((link_info->autoneg & BNXT_AUTONEG_FLOW_CTRL) &&
            (link_info->auto_pause_setting & BNXT_LINK_PAUSE_BOTH) !=
            link_info->req_flow_ctrl)