]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
serial: samsung: Remove useless spinlock
authorMarek Szyprowski <m.szyprowski@samsung.com>
Mon, 3 Apr 2017 06:21:01 +0000 (08:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 8 Apr 2017 16:58:52 +0000 (18:58 +0200)
Spinlock taken only for dma_map_single() for TX buffer is completely
useless and doesn't protect anything, so remove it to simplify the code.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/samsung.c

index ca0bcd7fd61f15a003da5d278b9913d714e1b2ba..8aca18c4cdea4076e8666baff7d7f4953d6a6e1f 100644 (file)
@@ -906,13 +906,9 @@ static int s3c24xx_serial_request_dma(struct s3c24xx_uart_port *p)
                goto err_free_rx;
        }
 
-       spin_lock_irqsave(&p->port.lock, flags);
-
        /* TX buffer */
        dma->tx_addr = dma_map_single(p->port.dev, p->port.state->xmit.buf,
                                UART_XMIT_SIZE, DMA_TO_DEVICE);
-
-       spin_unlock_irqrestore(&p->port.lock, flags);
        if (dma_mapping_error(p->port.dev, dma->tx_addr)) {
                ret = -EIO;
                goto err_unmap_rx;