]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
backlight: 88pm860x_bl: Use of_get_child_by_name() instead of refcount hack
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 14 Jan 2015 13:51:59 +0000 (14:51 +0100)
committerLee Jones <lee.jones@linaro.org>
Tue, 17 Feb 2015 14:55:37 +0000 (14:55 +0000)
of_find_node_by_name() calls of_node_put() on its "from" parameter.
To counter this, pm860x_backlight_dt_init() calls of_node_get() first.

Use of_get_child_by_name() instead to get rid of the refcount hack.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/video/backlight/88pm860x_bl.c

index 9a23698b6fe8398c1025ea3a234db11a4779ba09..2da5862876d1fe78fb53371bce64dde5269ad71b 100644 (file)
@@ -168,10 +168,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev,
        struct device_node *nproot, *np;
        int iset = 0;
 
-       nproot = of_node_get(pdev->dev.parent->of_node);
-       if (!nproot)
-               return -ENODEV;
-       nproot = of_find_node_by_name(nproot, "backlights");
+       nproot = of_get_child_by_name(pdev->dev.parent->of_node, "backlights");
        if (!nproot) {
                dev_err(&pdev->dev, "failed to find backlights node\n");
                return -ENODEV;