]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
rtc: sh: mark PM functions as unused
authorArnd Bergmann <arnd@arndb.de>
Wed, 19 Apr 2017 17:52:43 +0000 (19:52 +0200)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Sat, 22 Apr 2017 16:01:15 +0000 (18:01 +0200)
The sh_rtc_set_irq_wake() function is only called from the suspend/resume handlers
that may be hidden, causing a harmless warning:

drivers/rtc/rtc-sh.c:724:13: error: 'sh_rtc_set_irq_wake' defined but not used [-Werror=unused-function]
 static void sh_rtc_set_irq_wake(struct device *dev, int enabled)

The most reliable way to avoid the warning is to remove the existing #ifdef
and mark the two functions as __maybe_unused so the compiler can silently
drop all three when there is no reference.

Fixes: dab5aec64bf5 ("rtc: sh: add support for rza series")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-sh.c

index 00b396e96cbe90d8e6582812ca747314a029c1ce..6c2d3989f967baff96625ab39d0d19336b002def 100644 (file)
@@ -734,8 +734,7 @@ static void sh_rtc_set_irq_wake(struct device *dev, int enabled)
        }
 }
 
-#ifdef CONFIG_PM_SLEEP
-static int sh_rtc_suspend(struct device *dev)
+static int __maybe_unused sh_rtc_suspend(struct device *dev)
 {
        if (device_may_wakeup(dev))
                sh_rtc_set_irq_wake(dev, 1);
@@ -743,14 +742,13 @@ static int sh_rtc_suspend(struct device *dev)
        return 0;
 }
 
-static int sh_rtc_resume(struct device *dev)
+static int __maybe_unused sh_rtc_resume(struct device *dev)
 {
        if (device_may_wakeup(dev))
                sh_rtc_set_irq_wake(dev, 0);
 
        return 0;
 }
-#endif
 
 static SIMPLE_DEV_PM_OPS(sh_rtc_pm_ops, sh_rtc_suspend, sh_rtc_resume);