]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
[PATCH] kdump proc vmcore size oveflow fix
authorVivek Goyal <vgoyal@in.ibm.com>
Mon, 3 Apr 2006 23:38:11 +0000 (16:38 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Apr 2006 16:44:30 +0000 (09:44 -0700)
A couple of /proc/vmcore data structures overflow with 32bit systems having
memory more than 4G.  This patch fixes those.

Signed-off-by: Ken'ichi Ohmichi <oomichi@mxs.nes.nec.co.jp>
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/proc/vmcore.c
include/linux/proc_fs.h

index 4063fb32f78c210dd6c41690ff107966e68ed821..164a7d055e3f339979f80383588b3ff50e78e277 100644 (file)
@@ -103,8 +103,8 @@ static ssize_t read_vmcore(struct file *file, char __user *buffer,
                                size_t buflen, loff_t *fpos)
 {
        ssize_t acc = 0, tmp;
-       size_t tsz, nr_bytes;
-       u64 start;
+       size_t tsz;
+       u64 start, nr_bytes;
        struct vmcore *curr_m = NULL;
 
        if (buflen == 0 || *fpos >= vmcore_size)
index aa6322d4519828c4598cbab4c07116a2a615c385..6c1e3478775ab76620b4f52dba4d46ee4f0023d0 100644 (file)
@@ -78,7 +78,7 @@ struct kcore_list {
 struct vmcore {
        struct list_head list;
        unsigned long long paddr;
-       unsigned long size;
+       unsigned long long size;
        loff_t offset;
 };