]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
rtc: rtc-coh901331: remove unnecessary platform_set_drvdata()
authorJingoo Han <jg1.han@samsung.com>
Thu, 23 May 2013 00:37:43 +0000 (10:37 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Mon, 27 May 2013 06:09:18 +0000 (16:09 +1000)
The driver core clears the driver data to NULL after device_release or on
probe failure, since commit 0998d063100 ("device-core: Ensure drvdata =
NULL when no driver is bound").  Thus, it is not needed to manually clear
the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-coh901331.c

index 93c06588ddca58a18ec85025e0ef26f4e1945b3a..9ad58914601d01a2eea60e12082e5154cba783f3 100644 (file)
@@ -154,10 +154,8 @@ static int __exit coh901331_remove(struct platform_device *pdev)
 {
        struct coh901331_port *rtap = dev_get_drvdata(&pdev->dev);
 
-       if (rtap) {
+       if (rtap)
                clk_unprepare(rtap->clk);
-               platform_set_drvdata(pdev, NULL);
-       }
 
        return 0;
 }
@@ -220,7 +218,6 @@ static int __init coh901331_probe(struct platform_device *pdev)
        return 0;
 
  out_no_rtc:
-       platform_set_drvdata(pdev, NULL);
        clk_unprepare(rtap->clk);
        return ret;
 }