]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
staging: comedi: jr3_pci: pass transform by reference
authorIan Abbott <abbotti@mev.co.uk>
Fri, 17 Feb 2017 11:09:17 +0000 (11:09 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Mar 2017 08:16:58 +0000 (09:16 +0100)
Local function `set_transforms` has a parameter of type `struct
jr3_pci_transform`.  This has a size 32 bytes, which is quite large for
passing around in a function call.  Change it to use type `const struct
jr3_pci_transform *`.  (In practice, it is probably inlined by the
compiler anyway, but doing this seems to save a few bytes.)

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/jr3_pci.c

index 59030f3b382bfb8ec8939056105b20168bb6606c..997f97089df85bab639ee2870498783b2f22b6ae 100644 (file)
@@ -141,19 +141,19 @@ static int is_complete(struct jr3_channel __iomem *channel)
 }
 
 static void set_transforms(struct jr3_channel __iomem *channel,
-                          struct jr3_pci_transform transf, short num)
+                          const struct jr3_pci_transform *transf, short num)
 {
        int i;
 
        num &= 0x000f;          /* Make sure that 0 <= num <= 15 */
        for (i = 0; i < 8; i++) {
                set_u16(&channel->transforms[num].link[i].link_type,
-                       transf.link[i].link_type);
+                       transf->link[i].link_type);
                udelay(1);
                set_s16(&channel->transforms[num].link[i].link_amount,
-                       transf.link[i].link_amount);
+                       transf->link[i].link_amount);
                udelay(1);
-               if (transf.link[i].link_type == end_x_form)
+               if (transf->link[i].link_type == end_x_form)
                        break;
        }
 }
@@ -505,7 +505,7 @@ jr3_pci_poll_subdevice(struct comedi_subdevice *s)
                                transf.link[i].link_amount = 0;
                        }
 
-                       set_transforms(channel, transf, 0);
+                       set_transforms(channel, &transf, 0);
                        use_transform(channel, 0);
                        spriv->state = state_jr3_init_transform_complete;
                        /* Allow 20 ms for completion */