]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
NET: slip, fix ldisc->open retval
authorMatvejchikov Ilya <matvejchikov@gmail.com>
Fri, 6 May 2011 06:23:09 +0000 (06:23 +0000)
committerAndi Kleen <ak@linux.intel.com>
Mon, 1 Aug 2011 20:54:48 +0000 (13:54 -0700)
commit 057bef938896e6266ae24ec4266d24792d27c29a upstream.

TTY layer expects 0 if the ldisc->open operation succeeded.

Signed-off-by : Matvejchikov Ilya <matvejchikov@gmail.com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
drivers/net/slip.c

index fa434fb8fb7c087df16bacaf9108dfa3646e35db..fff62f477214faada167b8314666fa1304702201 100644 (file)
@@ -852,7 +852,9 @@ static int slip_open(struct tty_struct *tty)
        /* Done.  We have linked the TTY line to a channel. */
        rtnl_unlock();
        tty->receive_room = 65536;      /* We don't flow control */
-       return sl->dev->base_addr;
+
+       /* TTY layer expects 0 on success */
+       return 0;
 
 err_free_bufs:
        sl_free_bufs(sl);