]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
mmc: block: Fix cmd error reset failure path
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 13 Mar 2017 12:36:33 +0000 (14:36 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 14 Mar 2017 16:13:25 +0000 (17:13 +0100)
Commit 4e1f780032c5 ("mmc: block: break out mmc_blk_rw_cmd_abort()")
assumed the request had not completed, but in one case it had. Fix that.

Fixes: 4e1f780032c5 ("mmc: block: break out mmc_blk_rw_cmd_abort()")
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/block.c

index e59107ca512a5e3dada6ce5468f3b935507998c7..05afefcfb61114be2dc420680f51024571048c4a 100644 (file)
@@ -1701,7 +1701,8 @@ static void mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *new_req)
                case MMC_BLK_CMD_ERR:
                        req_pending = mmc_blk_rw_cmd_err(md, card, brq, old_req, req_pending);
                        if (mmc_blk_reset(md, card->host, type)) {
-                               mmc_blk_rw_cmd_abort(card, old_req);
+                               if (req_pending)
+                                       mmc_blk_rw_cmd_abort(card, old_req);
                                mmc_blk_rw_try_restart(mq, new_req);
                                return;
                        }