]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
md: wake up personality thread after array state update
authorTomasz Majchrzak <tomasz.majchrzak@intel.com>
Tue, 25 Oct 2016 15:07:08 +0000 (17:07 +0200)
committerShaohua Li <shli@fb.com>
Mon, 7 Nov 2016 23:08:21 +0000 (15:08 -0800)
When raid1/raid10 array fails to write to one of the drives, the request
is added to bio_end_io_list and finished by personality thread. The
thread doesn't handle it as long as MD_CHANGE_PENDING flag is set. In
case of external metadata this flag is cleared, however the thread is
not woken up. It causes request to be blocked for few seconds (until
another action on the array wakes up the thread) or to get stuck
indefinitely.

Wake up personality thread once MD_CHANGE_PENDING has been cleared.
Moving 'restart_array' call after the flag is cleared it not a solution
because in read-write mode the call doesn't wake up the thread.

Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/md.c

index 7f56d67471f696474c8a977043443eeeba80ec96..94f882af94aa66e1e04d6ab1c49dfb2ebf8a100a 100644 (file)
@@ -3922,6 +3922,7 @@ array_state_store(struct mddev *mddev, const char *buf, size_t len)
                if (st == active) {
                        restart_array(mddev);
                        clear_bit(MD_CHANGE_PENDING, &mddev->flags);
+                       md_wakeup_thread(mddev->thread);
                        wake_up(&mddev->sb_wait);
                        err = 0;
                } else /* st == clean */ {