]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ASoC: rsnd: fixup unsigned expression compared with zero: main_rate
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 16 Jun 2017 00:02:59 +0000 (00:02 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 21 Jun 2017 11:14:04 +0000 (12:14 +0100)
This patch fixes this WARNING

sound/soc/sh/rcar/ssi.c:285:5-14: WARNING: Unsigned expression\
compared with zero: main_rate < 0

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rcar/core.c
sound/soc/sh/rcar/rsnd.h
sound/soc/sh/rcar/ssi.c

index 4892c0a4b613259ed375013402bf8e9908352574..409bac331d274205d22d67e153b168e98b5a5c01 100644 (file)
@@ -763,7 +763,7 @@ static int rsnd_soc_hw_rule(struct rsnd_priv *priv,
                            struct snd_interval *baseline, struct snd_interval *iv)
 {
        struct snd_interval p;
-       int rate;
+       unsigned int rate;
        int i;
 
        snd_interval_any(&p);
index 9428d4e288dd5996fd8e4c3bfd7dd0de9999b7cb..99c57611df886a0700f7978cb93b5279b7c2498d 100644 (file)
@@ -680,7 +680,7 @@ int __rsnd_ssi_is_pin_sharing(struct rsnd_mod *mod);
 void rsnd_parse_connect_ssi(struct rsnd_dai *rdai,
                            struct device_node *playback,
                            struct device_node *capture);
-int rsnd_ssi_clk_query(struct rsnd_priv *priv,
+unsigned int rsnd_ssi_clk_query(struct rsnd_priv *priv,
                       int param1, int param2, int *idx);
 
 /*
index c8956c3484dd945c44e2f87063e1ee6bdc243839..46feddd78ee26f0e7fa90e40500914ef5b4edfe3 100644 (file)
@@ -208,14 +208,14 @@ u32 rsnd_ssi_multi_slaves_runtime(struct rsnd_dai_stream *io)
        return 0;
 }
 
-int rsnd_ssi_clk_query(struct rsnd_priv *priv,
+unsigned int rsnd_ssi_clk_query(struct rsnd_priv *priv,
                       int param1, int param2, int *idx)
 {
        int ssi_clk_mul_table[] = {
                1, 2, 4, 8, 16, 6, 12,
        };
        int j, ret;
-       int main_rate;
+       unsigned int main_rate;
 
        for (j = 0; j < ARRAY_SIZE(ssi_clk_mul_table); j++) {
 
@@ -245,7 +245,7 @@ int rsnd_ssi_clk_query(struct rsnd_priv *priv,
                return main_rate;
        }
 
-       return -EINVAL;
+       return 0;
 }
 
 static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
@@ -282,7 +282,7 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
        }
 
        main_rate = rsnd_ssi_clk_query(priv, rate, chan, &idx);
-       if (main_rate < 0) {
+       if (!main_rate) {
                dev_err(dev, "unsupported clock rate\n");
                return -EIO;
        }