]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
Staging: tm6000: remove unneeded check in get_next_buf()
authorDan Carpenter <error27@gmail.com>
Fri, 8 Jul 2011 07:25:40 +0000 (10:25 +0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 8 Jul 2011 21:06:38 +0000 (14:06 -0700)
We dereference "buf" on the line before so if it were NULL here we
would have OOPsed earlier.  Also list_entry() never returns NULL.
And finally, we handled the situation where the list is empty
earlier in the function.

So this test isn't needed and I've removed it.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/tm6000/tm6000-video.c

index 3fe603858f8f5a48c835f8d78528d8609e50801e..8d8b939915d8117116977f4372695e916d81198e 100644 (file)
@@ -179,9 +179,6 @@ static inline void get_next_buf(struct tm6000_dmaqueue *dma_q,
        *buf = list_entry(dma_q->active.next,
                        struct tm6000_buffer, vb.queue);
 
-       if (!buf)
-               return;
-
        /* Cleans up buffer - Useful for testing for frame/URB loss */
        outp = videobuf_to_vmalloc(&(*buf)->vb);