]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
pinctrl-sx150x: Fix incorrect constant in sx150x_init_hw
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Mon, 7 Nov 2016 16:53:13 +0000 (08:53 -0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 8 Nov 2016 08:36:48 +0000 (09:36 +0100)
According to the datasheet for SX1504/5/6, RegAdvanced's
"Autoclear NINT" bit that turns the feature when set and disables it
when cleared, so writing 0x04 to the register will have the opposite
from desirable effect.

Tested-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-sx150x.c

index 3ccd04840ab714e059b75e58582d868b348858c5..0e3e1daeeb7247fbdc32061c9edca4cf4b61a3e0 100644 (file)
@@ -942,7 +942,7 @@ static int sx150x_init_hw(struct sx150x_pinctrl *pctl)
        else if (pctl->data->model == SX150X_456)
                err = sx150x_i2c_write(pctl->client,
                                pctl->data->pri.x456.reg_advance,
-                               0x04);
+                               0x00);
        else
                err = sx150x_i2c_write(pctl->client,
                                pctl->data->pri.x123.reg_advance,