]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ALSA: usb-audio - Check the dB-range validity in the later read, too
authorTakashi Iwai <tiwai@suse.de>
Fri, 19 Aug 2011 06:30:53 +0000 (08:30 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 19 Aug 2011 06:30:53 +0000 (08:30 +0200)
When the initial check of dB-range failed due to the read error, try to
check again at the later read, too.  When an invalid dB range is found,
remove TLV flags and notify the mixer info change.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer.c

index cdd19d7fe500b2a6315b3023212f1313032c5999..78a5abda6793dc9069ed9ad4508126de4dd36874 100644 (file)
@@ -881,8 +881,17 @@ static int mixer_ctl_feature_info(struct snd_kcontrol *kcontrol, struct snd_ctl_
                uinfo->value.integer.min = 0;
                uinfo->value.integer.max = 1;
        } else {
-               if (! cval->initialized)
-                       get_min_max(cval,  0);
+               if (!cval->initialized) {
+                       get_min_max(cval, 0);
+                       if (cval->initialized && cval->dBmin >= cval->dBmax) {
+                               kcontrol->vd[0].access &= 
+                                       ~(SNDRV_CTL_ELEM_ACCESS_TLV_READ |
+                                         SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK);
+                               snd_ctl_notify(cval->mixer->chip->card,
+                                              SNDRV_CTL_EVENT_MASK_INFO,
+                                              &kcontrol->id);
+                       }
+               }
                uinfo->value.integer.min = 0;
                uinfo->value.integer.max =
                        (cval->max - cval->min + cval->res - 1) / cval->res;