]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
power: supply: axp20x_usb_power: Drop unnecessary static
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 4 May 2017 20:10:49 +0000 (22:10 +0200)
committerSebastian Reichel <sre@kernel.org>
Mon, 15 May 2017 13:28:14 +0000 (15:28 +0200)
Drop static on a local variable, when the variable is either first
initialized or never used, on every possible execution path through the
function.  The static has no benefit, and dropping it reduces the code
size.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

The change in code size is indicates by the following output from the size
command.

before:
   text    data     bss     dec     hex filename
   2865     252       8    3125     c35 drivers/power/supply/axp20x_usb_power.o

after:
   text    data     bss     dec     hex filename
   2822     252       0    3074     c02 drivers/power/supply/axp20x_usb_power.o

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
drivers/power/supply/axp20x_usb_power.c

index 2397c482656ebb2be64afd550a666ea840fa5fb5..44f70dcea61e3c7ac51086bb148ce894243ed933 100644 (file)
@@ -339,7 +339,7 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
                "VBUS_REMOVAL", "VBUS_VALID", "VBUS_NOT_VALID", NULL };
        static const char * const axp22x_irq_names[] = {
                "VBUS_PLUGIN", "VBUS_REMOVAL", NULL };
-       static const char * const *irq_names;
+       const char * const *irq_names;
        const struct power_supply_desc *usb_power_desc;
        int i, irq, ret;