]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
iscsi class: Fix freeing of skb in get host error path
authorMike Christie <michaelc@cs.wisc.edu>
Sun, 3 Aug 2014 23:37:52 +0000 (18:37 -0500)
committerChristoph Hellwig <hch@lst.de>
Mon, 4 Aug 2014 11:16:14 +0000 (13:16 +0200)
If get_host_stats failes we are using kfree to free the
skb. We should be using kfree_skb.

This patch was made over Christoph's scsi-queue drivers-for-3.17 branch.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/scsi_transport_iscsi.c

index 534d3fb87658500b928e658bf4d00ea48800306c..67d43e35693df9e9e119bb6a4c2faac56f1bc260 100644 (file)
@@ -3468,7 +3468,7 @@ iscsi_get_host_stats(struct iscsi_transport *transport, struct nlmsghdr *nlh)
 
                err = transport->get_host_stats(shost, buf, host_stats_size);
                if (err) {
-                       kfree(skbhost_stats);
+                       kfree_skb(skbhost_stats);
                        goto exit_host_stats;
                }