]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net: ethernet: nb8800: fix error return code in nb8800_open()
authorWei Yongjun <weiyongjun1@huawei.com>
Mon, 17 Oct 2016 15:31:58 +0000 (15:31 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Oct 2016 17:12:05 +0000 (13:12 -0400)
Fix to return error code -ENODEV from the of_phy_connect() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aurora/nb8800.c

index 453dc0967125cb55f0b2eae1a3bac8b2132f659e..99c40552ea9084d55dd8558d613f6e7f51bb92a5 100644 (file)
@@ -975,8 +975,10 @@ static int nb8800_open(struct net_device *dev)
        phydev = of_phy_connect(dev, priv->phy_node,
                                nb8800_link_reconfigure, 0,
                                priv->phy_mode);
-       if (!phydev)
+       if (!phydev) {
+               err = -ENODEV;
                goto err_free_irq;
+       }
 
        nb8800_pause_adv(dev);