]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
net: ethernet: lpc_eth: use phy_ethtool_{get|set}_link_ksettings
authorPhilippe Reynes <tremyfr@gmail.com>
Tue, 28 Jun 2016 21:59:45 +0000 (23:59 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 29 Jun 2016 12:15:33 +0000 (08:15 -0400)
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/nxp/lpc_eth.c

index b00350157d9e11976dd895efec31e2518d4f93ee..01b50ff7c7085f30a7fcf435f0ea0f2e852926ae 100644 (file)
@@ -1245,35 +1245,13 @@ static void lpc_eth_ethtool_setmsglevel(struct net_device *ndev, u32 level)
        pldat->msg_enable = level;
 }
 
-static int lpc_eth_ethtool_getsettings(struct net_device *ndev,
-       struct ethtool_cmd *cmd)
-{
-       struct phy_device *phydev = ndev->phydev;
-
-       if (!phydev)
-               return -EOPNOTSUPP;
-
-       return phy_ethtool_gset(phydev, cmd);
-}
-
-static int lpc_eth_ethtool_setsettings(struct net_device *ndev,
-       struct ethtool_cmd *cmd)
-{
-       struct phy_device *phydev = ndev->phydev;
-
-       if (!phydev)
-               return -EOPNOTSUPP;
-
-       return phy_ethtool_sset(phydev, cmd);
-}
-
 static const struct ethtool_ops lpc_eth_ethtool_ops = {
        .get_drvinfo    = lpc_eth_ethtool_getdrvinfo,
-       .get_settings   = lpc_eth_ethtool_getsettings,
-       .set_settings   = lpc_eth_ethtool_setsettings,
        .get_msglevel   = lpc_eth_ethtool_getmsglevel,
        .set_msglevel   = lpc_eth_ethtool_setmsglevel,
        .get_link       = ethtool_op_get_link,
+       .get_link_ksettings = phy_ethtool_get_link_ksettings,
+       .set_link_ksettings = phy_ethtool_set_link_ksettings,
 };
 
 static const struct net_device_ops lpc_netdev_ops = {