]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
rtc-ab8500-add-calibration-attribute-to-ab8500-rtc-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Thu, 8 Dec 2011 04:42:31 +0000 (15:42 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 13 Dec 2011 06:43:24 +0000 (17:43 +1100)
Cc: Alessandro Zummo <a.zummo@towertech.it>
WARNING: line over 80 characters
#48: FILE: drivers/rtc/rtc-ab8500.c:268:
+  * Check that the calibration value (which is in units of 0.5 parts-per-million)

ERROR: need consistent spacing around '-' (ctx:WxV)
#64: FILE: drivers/rtc/rtc-ab8500.c:284:
+ rtccal = ~(calibration -1) | 0x80;
                         ^

total: 1 errors, 1 warnings, 139 lines checked

./patches/rtc-ab8500-add-calibration-attribute-to-ab8500-rtc.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Linus Walleij <linus.walleij@stericsson.com>
Cc: Mark Godfrey <mark.godfrey@stericsson.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-ab8500.c

index 44edf1e38120dde6a3a3766236bd8f6985af18cb..d60d60599fbe1239b48ffc5644b84297fc6dc344 100644 (file)
@@ -281,7 +281,7 @@ static int ab8500_rtc_set_calibration(struct device *dev, int calibration)
        if (calibration >= 0)
                rtccal = 0x7F & calibration;
        else
-               rtccal = ~(calibration -1) | 0x80;
+               rtccal = ~(calibration - 1) | 0x80;
 
        retval = abx500_set_register_interruptible(dev, AB8500_RTC,
                        AB8500_RTC_CALIB_REG, rtccal);