]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ALSA: fm801: explicitly free IRQ line
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 18 Dec 2015 19:14:10 +0000 (21:14 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sun, 20 Dec 2015 21:31:53 +0000 (22:31 +0100)
Otherwise we will have a warning on ->remove() since device is a PCI one.

WARNING: CPU: 4 PID: 1411 at /home/andy/prj/linux/fs/proc/generic.c:575 remove_proc_entry+0x137/0x160()
remove_proc_entry: removing non-empty directory 'irq/21', leaking at least 'snd_fm801'

Fixes: 5618955c4269 (ALSA: fm801: move to pcim_* and devm_* functions)
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/fm801.c

index 1fdd92b6f18f377585b2c36813fcb9ff444fc691..f57847cc53c1977c10eb7883e1ec685acd3c2e6a 100644 (file)
@@ -1165,6 +1165,8 @@ static int snd_fm801_free(struct fm801 *chip)
        cmdw |= 0x00c3;
        fm801_writew(chip, IRQ_MASK, cmdw);
 
+       devm_free_irq(&chip->pci->dev, chip->irq, chip);
+
       __end_hw:
 #ifdef CONFIG_SND_FM801_TEA575X_BOOL
        if (!(chip->tea575x_tuner & TUNER_DISABLED)) {