]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
tg3: Remove unnecessary lock around tg3_flag_set
authorNithin Sujir <nsujir@broadcom.com>
Thu, 23 May 2013 11:11:27 +0000 (11:11 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 25 May 2013 05:23:30 +0000 (22:23 -0700)
The spinlock was needed when flags used to be a u32 and set/cleared
using bit operations. Now that we use the atomic set_bit, this lock
isn't needed.

Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/tg3.c

index bd5917d8ffb5edbf08c542aa63f27badf7c3b8e5..d7755d849e53ac490385d1ea5ff06c904ecfcde9 100644 (file)
@@ -6386,9 +6386,7 @@ static void tg3_tx_recover(struct tg3 *tp)
                    "Please report the problem to the driver maintainer "
                    "and include system chipset information.\n");
 
-       spin_lock(&tp->lock);
        tg3_flag_set(tp, TX_RECOVERY_PENDING);
-       spin_unlock(&tp->lock);
 }
 
 static inline u32 tg3_tx_avail(struct tg3_napi *tnapi)