]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
ipv4: Set skb->protocol properly for local output
authorEli Cooper <elicooper@gmx.com>
Thu, 1 Dec 2016 02:05:10 +0000 (10:05 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 2 Dec 2016 17:34:22 +0000 (12:34 -0500)
When xfrm is applied to TSO/GSO packets, it follows this path:

    xfrm_output() -> xfrm_output_gso() -> skb_gso_segment()

where skb_gso_segment() relies on skb->protocol to function properly.

This patch sets skb->protocol to ETH_P_IP before dst_output() is called,
fixing a bug where GSO packets sent through a sit tunnel are dropped
when xfrm is involved.

Cc: stable@vger.kernel.org
Signed-off-by: Eli Cooper <elicooper@gmx.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_output.c

index 105908d841a359bb433621b286398a2821852645..877bdb02e887f5cf7ce1c4610123484a22f89310 100644 (file)
@@ -107,6 +107,8 @@ int __ip_local_out(struct net *net, struct sock *sk, struct sk_buff *skb)
        if (unlikely(!skb))
                return 0;
 
+       skb->protocol = htons(ETH_P_IP);
+
        return nf_hook(NFPROTO_IPV4, NF_INET_LOCAL_OUT,
                       net, sk, skb, NULL, skb_dst(skb)->dev,
                       dst_output);