]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
staging: rtl8192u: ieee802111: Drop Useless Initialization
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Tue, 23 Feb 2016 21:27:57 +0000 (02:57 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
Removed initialisation of a varible if it is immediately reassigned.
Changes were made using Coccinelle.
@bad@
identifier i;
position p;
@@

i =@p <+...i...+>;

@@
type T;
constant C;
expression e;
identifier i;
position p != bad.p;
@@
T i
- = C
;
i =@p e;

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c

index 789b7c95b86ec55babe98fefc659520d2540bc60..28737ec65186a2d940fd71bf256c030eace574f7 100644 (file)
@@ -254,7 +254,7 @@ static struct sk_buff *ieee80211_DELBA(
 static void ieee80211_send_ADDBAReq(struct ieee80211_device *ieee,
                                    u8 *dst, PBA_RECORD pBA)
 {
-       struct sk_buff *skb = NULL;
+       struct sk_buff *skb;
        skb = ieee80211_ADDBA(ieee, dst, pBA, 0, ACT_ADDBAREQ); //construct ACT_ADDBAREQ frames so set statuscode zero.
 
        if (skb)
@@ -282,7 +282,7 @@ static void ieee80211_send_ADDBAReq(struct ieee80211_device *ieee,
 static void ieee80211_send_ADDBARsp(struct ieee80211_device *ieee, u8 *dst,
                                    PBA_RECORD pBA, u16 StatusCode)
 {
-       struct sk_buff *skb = NULL;
+       struct sk_buff *skb;
        skb = ieee80211_ADDBA(ieee, dst, pBA, StatusCode, ACT_ADDBARSP); //construct ACT_ADDBARSP frames
        if (skb)
        {
@@ -311,7 +311,7 @@ static void ieee80211_send_DELBA(struct ieee80211_device *ieee, u8 *dst,
                                 PBA_RECORD pBA, TR_SELECT TxRxSelect,
                                 u16 ReasonCode)
 {
-       struct sk_buff *skb = NULL;
+       struct sk_buff *skb;
        skb = ieee80211_DELBA(ieee, dst, pBA, TxRxSelect, ReasonCode); //construct ACT_ADDBARSP frames
        if (skb)
        {