]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
nvme-fc: don't bother to validate ioccsz and iorcsz
authorJames Smart <jsmart2021@gmail.com>
Fri, 17 Feb 2017 15:57:28 +0000 (07:57 -0800)
committerJens Axboe <axboe@fb.com>
Wed, 22 Feb 2017 20:34:00 +0000 (13:34 -0700)
Discovery controllers don't set the values. They are in reserved
areas of the Identify Controller data structure.

Given the cmd completed, the minimal capsule sizes are supported,
so no need to check nqn to detect discovery controllers and
special case validations.

Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/nvme/host/fc.c

index 6186fde718f9aacfa45b52220b5a9b0d2fea32df..9690beb15e69ab47bb04345da5f142ec56141035 100644 (file)
@@ -2353,18 +2353,6 @@ __nvme_fc_create_ctrl(struct device *dev, struct nvmf_ctrl_options *opts,
 
        /* sanity checks */
 
-       /* FC-NVME supports 64-byte SQE only */
-       if (ctrl->ctrl.ioccsz != 4) {
-               dev_err(ctrl->ctrl.device, "ioccsz %d is not supported!\n",
-                               ctrl->ctrl.ioccsz);
-               goto out_remove_admin_queue;
-       }
-       /* FC-NVME supports 16-byte CQE only */
-       if (ctrl->ctrl.iorcsz != 1) {
-               dev_err(ctrl->ctrl.device, "iorcsz %d is not supported!\n",
-                               ctrl->ctrl.iorcsz);
-               goto out_remove_admin_queue;
-       }
        /* FC-NVME does not have other data in the capsule */
        if (ctrl->ctrl.icdoff) {
                dev_err(ctrl->ctrl.device, "icdoff %d is not supported!\n",