]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
isdn: gigaset: add missing unlock
authorDan Carpenter <error27@gmail.com>
Thu, 5 Aug 2010 22:23:23 +0000 (22:23 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 26 Aug 2010 23:43:52 +0000 (16:43 -0700)
commit 7e27a0aeb98d53539bdc38384eee899d6db62617 upstream.

We should unlock here.  This is the only place where we return from the
function with the lock held.  The caller isn't expecting it.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/isdn/gigaset/capi.c

index 4bf54712020c2148ff24797ca0bbe940d0349e1f..b4093f27de34c207639da2e6667c06b08b12ee20 100644 (file)
@@ -1055,6 +1055,7 @@ static inline void remove_appl_from_channel(struct bc_state *bcs,
        do {
                if (bcap->bcnext == ap) {
                        bcap->bcnext = bcap->bcnext->bcnext;
+                       spin_unlock_irqrestore(&bcs->aplock, flags);
                        return;
                }
                bcap = bcap->bcnext;