From: Vasiliy Kulikov <segoon@openwall.com>
Date: Fri, 4 Feb 2011 12:23:56 +0000 (+0300)
Subject: platform: x86: acer-wmi: world-writable sysfs threeg file
X-Git-Tag: v2.6.33.8~121
X-Git-Url: https://git.kernelconcepts.de/?a=commitdiff_plain;h=c752d4bb18aff38e932110f271babc58d3cfe8eb;p=karo-tx-linux.git

platform: x86: acer-wmi: world-writable sysfs threeg file

commit b80b168f918bba4b847e884492415546b340e19d upstream.

Don't allow everybody to write to hardware registers.

Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index f8c2da1e1c70..827caf4e09c1 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -1062,7 +1062,7 @@ static ssize_t set_bool_threeg(struct device *dev,
 			return -EINVAL;
 	return count;
 }
-static DEVICE_ATTR(threeg, S_IWUGO | S_IRUGO | S_IWUSR, show_bool_threeg,
+static DEVICE_ATTR(threeg, S_IRUGO | S_IWUSR, show_bool_threeg,
 	set_bool_threeg);
 
 static ssize_t show_interface(struct device *dev, struct device_attribute *attr,