]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
perf tools, x86: Fix 32-bit compile on 64-bit system
authorDavid Ahern <dsahern@gmail.com>
Mon, 11 Jul 2011 21:38:24 +0000 (15:38 -0600)
committerIngo Molnar <mingo@elte.hu>
Thu, 21 Jul 2011 11:42:30 +0000 (13:42 +0200)
commit08a4a43fc407d780bdde36d98f89c0dbb2a6be6b
tree2ec7649b3a6423d633508f1a293920d8f5ee8665
parentcf6ace16a3cd8b728fb0afa68368fd40bbeae19f
perf tools, x86: Fix 32-bit compile on 64-bit system

Builds for 32-bit perf binaries on a 64-bit host currently fail
with this error:

 [...]
 bench/../../../arch/x86/lib/memcpy_64.S: Assembler messages:
 bench/../../../arch/x86/lib/memcpy_64.S:29: Error: bad register name `%rdi'
 bench/../../../arch/x86/lib/memcpy_64.S:34: Error: invalid instruction suffix for `movs'
 bench/../../../arch/x86/lib/memcpy_64.S:50: Error: bad register name `%rdi'
 bench/../../../arch/x86/lib/memcpy_64.S:61: Error: bad register name `%rdi'
 ...

The problem is the detection of the host arch without considering passed in
flags. This change fixes 32-bit builds via:

make EXTRA_CFLAGS=-m32

and 64-bit builds still reference the memcpy_64.S.

Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: <stable@kernel.org>
Link: http://lkml.kernel.org/r/1310420304-21452-1-git-send-email-dsahern@gmail.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
tools/perf/Makefile