]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ARM: virt: simplify __hyp_stub_install epilog
authorMarc Zyngier <marc.zyngier@arm.com>
Fri, 4 Jan 2013 17:44:15 +0000 (17:44 +0000)
committerWill Deacon <will.deacon@arm.com>
Thu, 10 Jan 2013 21:08:55 +0000 (21:08 +0000)
commitd01723479e6a6c70c83295f7847477a016d5e14a
tree11daf853183da10d5177876716a4b2771e642e70
parent6e484be1ccca3ea495db45900fd42aac8d49d754
ARM: virt: simplify __hyp_stub_install epilog

__hyp_stub_install duplicates quite a bit of safe_svcmode_maskall
by forcing the CPU back to SVC. This is unnecessary, as
safe_svcmode_maskall is called just after.

Furthermore, the way we build SPSR_hyp is buggy as we fail to mask
the interrupts, leading to interesting behaviours on TC2 + UEFI.

The fix is to simply remove this code and rely on safe_svcmode_maskall
to do the right thing.

Cc: <stable@vger.kernel.org>
Reviewed-by: Dave Martin <dave.martin@linaro.org>
Reported-by: Harry Liebel <harry.liebel@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm/kernel/hyp-stub.S