pwm: deprecate of_pwm_xlate_with_flags()

[karo-tx-linux.git] / drivers / pwm / core.c

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index dfbfbc5217683de697d1c834f73c55de0ff850de..0b0a733486564029d1153a2634f07210ed9cae34 100644 (file)
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -30,10 +30,9 @@
 #include <linux/debugfs.h>
 #include <linux/seq_file.h>
 
-#define MAX_PWMS 1024
+#include <dt-bindings/pwm/pwm.h>
 
-/* flags in the third cell of the DT PWM specifier */
-#define PWM_SPEC_POLARITY      (1 << 0)
+#define MAX_PWMS 1024
 
 static DEFINE_MUTEX(pwm_lookup_lock);
 static LIST_HEAD(pwm_lookup_list);
@@ -132,12 +131,12 @@ static int pwm_device_request(struct pwm_device *pwm, const char *label)
        return 0;
 }
 
-struct pwm_device *
-of_pwm_xlate_with_flags(struct pwm_chip *pc, const struct of_phandle_args *args)
+static struct pwm_device *of_pwm_xlate(struct pwm_chip *pc,
+                               const struct of_phandle_args *args)
 {
        struct pwm_device *pwm;
 
-       if (pc->of_pwm_n_cells < 3)
+       if (pc->of_pwm_n_cells < 2)
                return ERR_PTR(-EINVAL);
 
        if (args->args[0] >= pc->npwm)
@@ -149,34 +148,24 @@ of_pwm_xlate_with_flags(struct pwm_chip *pc, const struct of_phandle_args *args)
 
        pwm_set_period(pwm, args->args[1]);
 
-       if (args->args[2] & PWM_SPEC_POLARITY)
+       if (pc->of_pwm_n_cells < 3)
+               return pwm;
+
+       if (args->args[2] & PWM_POLARITY_INVERTED)
                pwm_set_polarity(pwm, PWM_POLARITY_INVERSED);
        else
                pwm_set_polarity(pwm, PWM_POLARITY_NORMAL);
 
        return pwm;
 }
-EXPORT_SYMBOL_GPL(of_pwm_xlate_with_flags);
 
-static struct pwm_device *
-of_pwm_simple_xlate(struct pwm_chip *pc, const struct of_phandle_args *args)
+struct pwm_device *
+__deprecated of_pwm_xlate_with_flags(struct pwm_chip *pc,
+                               const struct of_phandle_args *args)
 {
-       struct pwm_device *pwm;
-
-       if (pc->of_pwm_n_cells < 2)
-               return ERR_PTR(-EINVAL);
-
-       if (args->args[0] >= pc->npwm)
-               return ERR_PTR(-EINVAL);
-
-       pwm = pwm_request_from_chip(pc, args->args[0], NULL);
-       if (IS_ERR(pwm))
-               return pwm;
-
-       pwm_set_period(pwm, args->args[1]);
-
-       return pwm;
+       return of_pwm_xlate(pc, args);
 }
+EXPORT_SYMBOL_GPL(of_pwm_xlate_with_flags);
 
 static void of_pwmchip_add(struct pwm_chip *chip)
 {
@@ -184,7 +173,7 @@ static void of_pwmchip_add(struct pwm_chip *chip)
                return;
 
        if (!chip->of_xlate) {
-               chip->of_xlate = of_pwm_simple_xlate;
+               chip->of_xlate = of_pwm_xlate;
                chip->of_pwm_n_cells = 2;
        }
 
@@ -526,24 +515,17 @@ struct pwm_device *of_pwm_get(struct device_node *np, const char *con_id)
        err = of_parse_phandle_with_args(np, "pwms", "#pwm-cells", index,
                                         &args);
        if (err) {
-               pr_debug("%s(): can't parse \"pwms\" property\n", __func__);
+               pr_err("%s(): can't parse \"pwms\" property\n", __func__);
                return ERR_PTR(err);
        }
 
        pc = of_node_to_pwmchip(args.np);
        if (IS_ERR(pc)) {
-               pr_debug("%s(): PWM chip not found\n", __func__);
+               pr_err("%s(): PWM chip not found\n", __func__);
                pwm = ERR_CAST(pc);
                goto put;
        }
 
-       if (args.args_count != pc->of_pwm_n_cells) {
-               pr_debug("%s: wrong #pwm-cells for %s\n", np->full_name,
-                        args.np->full_name);
-               pwm = ERR_PTR(-EINVAL);
-               goto put;
-       }
-
        pwm = pc->of_xlate(pc, &args);
        if (IS_ERR(pwm))
                goto put;