]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
remoteproc: qcom: mdt_loader: Use signed type for offset
authorBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 15 Feb 2017 22:00:41 +0000 (14:00 -0800)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Wed, 22 Feb 2017 10:07:13 +0000 (02:07 -0800)
commit01625cc5e65f420dbea57f7de6b9552a0f807a84
treedb133dd5046653862d136263a1238a185278d84a
parent231c8dfd1a9ff530869e1327ba4168dbe592f3f9
remoteproc: qcom: mdt_loader: Use signed type for offset

In the transition from using rproc_da_to_va(), the type of the load
offset became unsigned. This causes the subsequent check to let negative
values less than p_memsz + mem_size through and we write outside of the
buffer.

Change the type back to a signed value to catch this.

Fixes: 7f0dd07a9b29 ("remoteproc: qcom: mdt_loader: Refactor MDT loader")
Fixes: e7fd25226295 ("remoteproc: qcom: q6v5: Decouple driver from MDT loader")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Acked-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_q6v5_pil.c
drivers/soc/qcom/mdt_loader.c