]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[PATCH] firmware: fix BUG: in fw_realloc_buffer
authorJeff Moyer <jmoyer@redhat.com>
Mon, 13 Feb 2006 22:52:38 +0000 (14:52 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 28 Mar 2006 06:47:30 +0000 (22:47 -0800)
commit048eb7e760ef41bcfef09bbd223f18379d260c2c
treee7adc2b593ec6f8ccea5c647506598d43b257d89
parenta15dee13761dd8521e5410a942574afa4375f6c6
[PATCH] firmware: fix BUG: in fw_realloc_buffer

The fw_realloc_buffer routine does not handle an increase in buffer size of
more than 4k.  It's not clear to me why it expects that it will only get an
extra 4k of data.  The attached patch modifies fw_realloc_buffer to vmalloc
as much memory as is requested, instead of what we previously had + 4k.

I've tested this on my laptop, which would crash occaisionally on boot
without the patch.  With the patch, it hasn't crashed, but I can't be
certain that this code path is exercised.

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/base/firmware_class.c