]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
phy: brcmstb-sata: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 16 Nov 2015 11:33:14 +0000 (12:33 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Thu, 3 Dec 2015 06:58:23 +0000 (12:28 +0530)
commit0b25ff8697d8074cee22269226c210605f97ec1b
tree119b635dd55f7606dbf723a9c9f4edfa930f5369
parent97dc5bf8d60938741e2f99242dff3684c29b6d90
phy: brcmstb-sata: add missing of_node_put

for_each_available_child_of_node performs an of_node_get on each iteration,
so a return from the middle of the loop requires an of_node_put.

A simplified version of the semantic patch that finds this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_available_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
*  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-brcmstb-sata.c