]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm/i915/bxt: Avoid early timeout during PLL enable
authorImre Deak <imre.deak@intel.com>
Tue, 28 Jun 2016 10:37:30 +0000 (13:37 +0300)
committerImre Deak <imre.deak@intel.com>
Tue, 28 Jun 2016 19:10:16 +0000 (22:10 +0300)
commit0b786e41c73956126f6297764459021deef8aba7
treea279d9f314497d648077c14007a1390d9f3ccd48
parent9b6130227495fdaf17f8b3b28db083666b113c84
drm/i915/bxt: Avoid early timeout during PLL enable

Since wait_for_atomic doesn't re-check the wait-for condition after
expiry of the timeout it can fail when called from non-atomic context
even if the condition is set correctly before the expiry. Fix this by
using the non-atomic wait_for instead.

I noticed this via the PLL locking timing out incorrectly, with this fix
I couldn't reproduce the problem.

Fixes: 0351b93992aa ("drm/i915: Do not lie about atomic timeout granularity")
CC: Chris Wilson <chris@chris-wilson.co.uk>
CC: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
CC: drm-intel-fixes@lists.freedesktop.org
Link: http://patchwork.freedesktop.org/patch/msgid/1467110253-16046-2-git-send-email-imre.deak@intel.com
drivers/gpu/drm/i915/intel_dpll_mgr.c