]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
xfs: prevent reading uninitialized stack memory
authorDan Rosenberg <dan.j.rosenberg@gmail.com>
Mon, 6 Sep 2010 22:24:57 +0000 (18:24 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 27 Sep 2010 00:18:36 +0000 (17:18 -0700)
commit0d1f22d21f4ca1fe9943667b712beb4d80611236
treed1480f6ed61b21bbe1eea14e27b2244efa2c5706
parent0f403655ecddfdb7630adbb6ba59c30cb0c541a4
xfs: prevent reading uninitialized stack memory

commit a122eb2fdfd78b58c6dd992d6f4b1aaef667eef9 upstream.

The XFS_IOC_FSGETXATTR ioctl allows unprivileged users to read 12
bytes of uninitialized stack memory, because the fsxattr struct
declared on the stack in xfs_ioc_fsgetxattr() does not alter (or zero)
the 12-byte fsx_pad member before copying it back to the user.  This
patch takes care of it.

Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
Cc: dann frazier <dannf@debian.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/xfs/linux-2.6/xfs_ioctl.c