]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
md: raid5: fix clearing of biofill operations
authorDan Williams <dan.j.williams@intel.com>
Tue, 23 Oct 2007 03:45:11 +0000 (20:45 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 16 Nov 2007 17:30:22 +0000 (09:30 -0800)
commit1094650c9b3d035380ae3f5add3debea89007113
tree598a0390514ca74585ac2ab29cc9bd1526d5dd71
parent67663d780910f8f9621c874802bb04f2c9dcda25
md: raid5: fix clearing of biofill operations

raid5: fix clearing of biofill operations

This is the correct merge of the two upstream patches for this issue (it
was mis-merged...)

ops_complete_biofill() runs outside of spin_lock(&sh->lock) and clears the
'pending' and 'ack' bits.  Since the test_and_ack_op() macro only checks
against 'complete' it can get an inconsistent snapshot of pending work.

Move the clearing of these bits to handle_stripe5(), under the lock.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Tested-by: Joel Bertrand <joel.bertrand@systella.fr>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/md/raid5.c