]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86/mm/kaslr: Use the _ASM_MUL macro for multiplication to work around Clang incompat...
authorMatthias Kaehlcke <mka@chromium.org>
Mon, 1 May 2017 22:47:41 +0000 (15:47 -0700)
committerIngo Molnar <mingo@kernel.org>
Fri, 5 May 2017 06:31:05 +0000 (08:31 +0200)
commit121843eb02a6e2fa30aefab64bfe183c97230c75
tree72e56dafd21ade241842af08ec79b13a76178b5b
parentfc5f9d5f151c9fff21d3d1d2907b888a5aec3ff7
x86/mm/kaslr: Use the _ASM_MUL macro for multiplication to work around Clang incompatibility

The constraint "rm" allows the compiler to put mix_const into memory.
When the input operand is a memory location then MUL needs an operand
size suffix, since Clang can't infer the multiplication width from the
operand.

Add and use the _ASM_MUL macro which determines the operand size and
resolves to the NUL instruction with the corresponding suffix.

This fixes the following error when building with clang:

  CC      arch/x86/lib/kaslr.o
  /tmp/kaslr-dfe1ad.s: Assembler messages:
  /tmp/kaslr-dfe1ad.s:182: Error: no instruction mnemonic suffix given and no register operands; can't size instruction

Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Cc: Grant Grundler <grundler@chromium.org>
Cc: Greg Hackmann <ghackmann@google.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Michael Davidson <md@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20170501224741.133938-1-mka@chromium.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/asm.h
arch/x86/lib/kaslr.c