]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
coredump: prevent double-free on an error path in core dumper
authorDenys Vlasenko <vda.linux@googlemail.com>
Wed, 26 Sep 2012 01:34:50 +0000 (11:34 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 27 Sep 2012 07:28:41 +0000 (17:28 +1000)
commit1482b1069f1d4ecc09d5a1ecd416a8c0be8ef869
tree21f134e6eae5c75ae00450d4126093e572fbd13e
parentc4eb2e8fd9a1f5055c7abc80d91ca16578216acb
coredump: prevent double-free on an error path in core dumper

In !CORE_DUMP_USE_REGSET case, if elf_note_info_init fails to allocate
memory for info->fields, it frees already allocated stuff and returns
error to its caller, fill_note_info.  Which in turn returns error to its
caller, elf_core_dump.  Which jumps to cleanup label and calls
free_note_info, which will happily try to free all info->fields again.
BOOM.

This is the fix.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/binfmt_elf.c