]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
USB: serial/mos*: prevent reading uninitialized stack memory
authorDan Rosenberg <drosenberg@vsecurity.com>
Wed, 15 Sep 2010 21:44:16 +0000 (17:44 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 27 Sep 2010 00:18:10 +0000 (17:18 -0700)
commit150e749ab763aef866fcc1d28e25371a39e7fcc1
treec62263be79e8ee120d0d0b9bb115ef90070cdd26
parent6c09969e0edfbc991387436eb011d5c7642b2b6a
USB: serial/mos*: prevent reading uninitialized stack memory

commit a0846f1868b11cd827bdfeaf4527d8b1b1c0b098 upstream.

The TIOCGICOUNT device ioctl in both mos7720.c and mos7840.c allows
unprivileged users to read uninitialized stack memory, because the
"reserved" member of the serial_icounter_struct struct declared on the
stack is not altered or zeroed before being copied back to the user.
This patch takes care of it.

Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/mos7720.c
drivers/usb/serial/mos7840.c