]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
KVM: arm/arm64: vgic-v3: Use PREbits to infer the number of ICH_APxRn_EL2 registers
authorMarc Zyngier <marc.zyngier@arm.com>
Tue, 2 May 2017 13:30:41 +0000 (14:30 +0100)
committerChristoffer Dall <cdall@linaro.org>
Mon, 15 May 2017 09:32:04 +0000 (11:32 +0200)
commit15d2bffdde6268883647c6112970f74d3e1af651
treec30636f3152d7d074fe41097fc349aa4432504b1
parent3d6e77ad1489650afa20da92bb589c8778baa8da
KVM: arm/arm64: vgic-v3: Use PREbits to infer the number of ICH_APxRn_EL2 registers

The GICv3 documentation is extremely confusing, as it talks about
the number of priorities represented by the ICH_APxRn_EL2 registers,
while it should really talk about the number of preemption levels.

This leads to a bug where we may access undefined ICH_APxRn_EL2
registers, since PREbits is allowed to be smaller than PRIbits.
Thankfully, nobody seem to have taken this path so far...

The fix is to use ICH_VTR_EL2.PREbits instead.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Reviewed-by: Christoffer Dall <cdall@linaro.org>
Signed-off-by: Christoffer Dall <cdall@linaro.org>
virt/kvm/arm/hyp/vgic-v3-sr.c