]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
sky2: Fix oops in sky2_xmit_frame() after TX timeout
authorJarek Poplawski <jarkao2@gmail.com>
Mon, 4 Jan 2010 08:48:41 +0000 (08:48 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 9 Feb 2010 12:50:55 +0000 (04:50 -0800)
commit16813330e739634925b347804d1e6a99b71c6399
treeba0cfb5cf743c288a84f43130fbef180fb202341
parent16b8efad28d99afaf50b2a2116bf8edf605a0912
sky2: Fix oops in sky2_xmit_frame() after TX timeout

[ Upstream commit 9db2f1bec36805e57a003f7bb90e003815d96de8 ]

During TX timeout procedure dev could be awoken too early, e.g. by
sky2_complete_tx() called from sky2_down(). Then sky2_xmit_frame()
can run while buffers are freed causing an oops. This patch fixes it
by adding netif_device_present() test in sky2_tx_complete().

Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=14925
With debugging by: Mike McCormack <mikem@ring3k.org>

Reported-by: Berck E. Nash <flyboy@gmail.com>
Tested-by: Berck E. Nash <flyboy@gmail.com>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/sky2.c