]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: Fix recursive descent in __scm_destroy().
authorDavid Miller <davem@davemloft.net>
Thu, 6 Nov 2008 08:37:40 +0000 (00:37 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 7 Nov 2008 17:55:19 +0000 (09:55 -0800)
commit1dbbd0bf5d15397a4e4a1ae3e3e82e0fe4f83c3a
tree78ed4f68eb606e367797b522e11b21a917f168c1
parentdcc5bc3d9f306cbb5e2f55d65bce1c8372b25fde
net: Fix recursive descent in __scm_destroy().

commit f8d570a4745835f2238a33b537218a1bb03fc671 and
3b53fbf4314594fa04544b02b2fc6e607912da18 upstream (because once wasn't
good enough...)

__scm_destroy() walks the list of file descriptors in the scm_fp_list
pointed to by the scm_cookie argument.

Those, in turn, can close sockets and invoke __scm_destroy() again.

There is nothing which limits how deeply this can occur.

The idea for how to fix this is from Linus.  Basically, we do all of
the fput()s at the top level by collecting all of the scm_fp_list
objects hit by an fput().  Inside of the initial __scm_destroy() we
keep running the list until it is empty.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/sched.h
include/net/scm.h
net/core/scm.c