]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
parisc: isa-eeprom - Fix loff_t usage
authorMichael Buesch <mb@bu3sch.de>
Mon, 20 Jul 2009 22:58:44 +0000 (22:58 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 1 Apr 2010 22:52:25 +0000 (15:52 -0700)
commit1f059b24d2a9f0f15766d0f77acaaa3c8a163a3a
tree3cd978e2468524ef70a29a0016b5259114dfc3ed
parent910e88a0698da1f483603c603b04c780cb87dd08
parisc: isa-eeprom - Fix loff_t usage

commit 6b4dbcd86a9d464057fcc7abe4d0574093071fcc upstream.

loff_t is a signed type. If userspace passes a negative ppos, the "count"
range check is weakened. "count"s bigger than HPEE_MAX_LENGTH will pass the check.
Also, if ppos is negative, the readb(eisa_eeprom_addr + *ppos) will poke in random
memory.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/parisc/eisa_eeprom.c