]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
PowerCap: Fix an error code in powercap_register_zone()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 10 May 2017 19:40:06 +0000 (22:40 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 14 May 2017 11:30:05 +0000 (13:30 +0200)
commit216c4e9db4c9d1d2a382b42880442dc632cd47d9
tree68c8fc3ef185f9da03feacfec23c79b314c58650
parent4486740da2e1cb307f58e0e62f94c92ec7c101a1
PowerCap: Fix an error code in powercap_register_zone()

In the current code we accidentally return the successful result from
idr_alloc() instead of a negative error pointer.  The caller is looking
for an error pointer and so it treats the returned value as a valid
pointer.

This one might be a bit serious because if it lets people get around the
kernel's protection for remapping NULL.  I'm not sure.

Fixes: 75d2364ea0ca (PowerCap: Add class driver)
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/powercap/powercap_sys.c