]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ALSA: HDA: Fix Oops caused by dereference NULL pointer
authorWang YanQing <udknight@gmail.com>
Tue, 7 May 2013 03:27:33 +0000 (11:27 +0800)
committerTakashi Iwai <tiwai@suse.de>
Tue, 7 May 2013 05:31:59 +0000 (07:31 +0200)
commit2195b063f6609e4c6268f291683902f25eaf9aa6
tree49673707b98bf6aa4dd3a150583d8137bc32568f
parent5a4ca9b3fa24f81298c13a27c03c6dd4087ca159
ALSA: HDA: Fix Oops caused by dereference NULL pointer

The interrupt handler azx_interrupt will call azx_update_rirb,
which may call snd_hda_queue_unsol_event, snd_hda_queue_unsol_event
will dereference chip->bus pointer.

The problem is we alloc chip->bus in azx_codec_create
which will be called after we enable IRQ and enable unsolicited
event in azx_probe.

This will cause Oops due dereference NULL pointer. I meet it, good luck:)

[Rearranged the NULL check before the tracepoint and added another
 NULL check of bus->workq -- tiwai]

Signed-off-by: Wang YanQing <udknight@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_codec.c