]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
sky2: enable rx/tx in sky2_phy_reinit()
authorBrandon Philips <brandon@ifup.org>
Wed, 16 Jun 2010 16:21:58 +0000 (16:21 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:18:50 +0000 (10:18 -0700)
commit2339fdd79dfe5f17b0b44d89a9475aa8f912be2a
tree4aa54c633bfd44ca6e2f8b5c7be3bf9261c0042a
parent1a9e5fa66baa4dfd6bc366fbe84b172c6da9321b
sky2: enable rx/tx in sky2_phy_reinit()

commit 38000a94a902e94ca8b5498f7871c6316de8957a upstream.

sky2_phy_reinit is called by the ethtool helpers sky2_set_settings,
sky2_nway_reset and sky2_set_pauseparam when netif_running.

However, at the end of sky2_phy_init GM_GP_CTRL has GM_GPCR_RX_ENA and
GM_GPCR_TX_ENA cleared. So, doing these commands causes the device to
stop working:

$ ethtool -r eth0
$ ethtool -A eth0 autoneg off

Fix this issue by enabling Rx/Tx after running sky2_phy_init in
sky2_phy_reinit.

Signed-off-by: Brandon Philips <bphilips@suse.de>
Tested-by: Brandon Philips <bphilips@suse.de>
Cc: stable@kernel.org
Tested-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/sky2.c