]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[PATCH] select_bad_process(): kill a bogus PF_DEAD/TASK_DEAD check
authorOleg Nesterov <oleg@tv-sign.ru>
Fri, 29 Sep 2006 09:01:12 +0000 (02:01 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 29 Sep 2006 16:18:21 +0000 (09:18 -0700)
commit28324d1df646521256e83389244adcce98e89ff2
treeaaa81642185611b4996daeba7d65e6b3c3eb05a7
parentc394cc9fbb367f87faa2228ec2eabacd2d4701c6
[PATCH] select_bad_process(): kill a bogus PF_DEAD/TASK_DEAD check

The only one usage of TASK_DEAD outside of last schedule path,

select_bad_process:

for_each_task(p) {

if (!p->mm)
continue;
...
if (p->state == TASK_DEAD)
continue;
...

TASK_DEAD state is set at the end of do_exit(), this means that p->mm
was already set == NULL by exit_mm(), so this task was already rejected
by 'if (!p->mm)' above.

Note also that the caller holds tasklist_lock, this means that p can't
pass exit_notify() and then set TASK_DEAD when p->mm != NULL.

Also, remove open-coded is_init().

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
mm/oom_kill.c