]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
target: Don't set WBUS16 or SYNC bits in INQUIRY response
authorRoland Dreier <roland@purestorage.com>
Tue, 14 Feb 2012 00:18:16 +0000 (16:18 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 2 Apr 2012 16:27:12 +0000 (09:27 -0700)
commit2a540015f107ec0b073725ab7575bd7990e094d9
tree557951dafc2d307bb49b42d0ab4d4e8fdc13828f
parent17ec4b6b1cec2c86973604ffaae50a1604c1637c
target: Don't set WBUS16 or SYNC bits in INQUIRY response

commit effc6cc8828257c32c37635e737f14fd6e19ecd7 upstream.

SPC-4 says about the WBUS16 and SYNC bits:

    The meanings of these fields are specific to SPI-5 (see 6.4.3).
    For SCSI transport protocols other than the SCSI Parallel
    Interface, these fields are reserved.

We don't have a SPI fabric module, so we should never set these bits.
(The comment was misleading, since it only mentioned Sync but the
actual code set WBUS16 too).

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/target/target_core_cdb.c