]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
fix d_walk()/non-delayed __d_free() race
authorAl Viro <viro@zeniv.linux.org.uk>
Wed, 8 Jun 2016 01:26:55 +0000 (21:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Jun 2016 17:18:21 +0000 (10:18 -0700)
commit2b11d80e1aa70b56c6431e4dc3c686ffc61a73bf
tree2a0c3d92db21ff8416b84648d495d26f81ea0c2f
parentc08b1a593a042ae01e788ec5504bee2cfc83e1f2
fix d_walk()/non-delayed __d_free() race

commit 3d56c25e3bb0726a5c5e16fc2d9e38f8ed763085 upstream.

Ascend-to-parent logics in d_walk() depends on all encountered child
dentries not getting freed without an RCU delay.  Unfortunately, in
quite a few cases it is not true, with hard-to-hit oopsable race as
the result.

Fortunately, the fix is simiple; right now the rule is "if it ever
been hashed, freeing must be delayed" and changing it to "if it
ever had a parent, freeing must be delayed" closes that hole and
covers all cases the old rule used to cover.  Moreover, pipes and
sockets remain _not_ covered, so we do not introduce RCU delay in
the cases which are the reason for having that delay conditional
in the first place.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/dcache.c