]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
pktcdvd: removing device does not remove its sysfs dir
authorThadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Tue, 2 Feb 2010 21:44:17 +0000 (13:44 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 9 Feb 2010 12:51:01 +0000 (04:51 -0800)
commit2c7f87e9dc8167999d4169b58f4be04fd357e9eb
tree54771d19db112497182a0b4876d6faab19399cb0
parentb31aa5cccb9b5850135c07d8a0cb22984a5fe0f2
pktcdvd: removing device does not remove its sysfs dir

commit ca0bf64d99f6e3f6e2fe2585e52a0ac57354beac upstream.

This is the counterpart to cba767175becadc5c4016cceb7bfdd2c7fe722f4
("pktcdvd: remove broken dev_t export of class devices").  Device is not
registered using dev_t, so it should not be destroyed using device_destroy
which looks up the device by dev_t.  This will fail and adding the device
again will fail with the "duplicate name" error.  This is fixed using
device_unregister instead of device_destroy.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Peter Osterlund <petero2@telia.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/block/pktcdvd.c