]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
IB/mthca: Use mmiowb() to avoid firmware commands getting jumbled up
authorRoland Dreier <rdreier@cisco.com>
Fri, 12 Oct 2007 21:47:25 +0000 (14:47 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 16 Nov 2007 17:30:20 +0000 (09:30 -0800)
commit306a49e91130973abd5e1ca8be299e062afdef52
tree3e41dd5929208712f72f9b2ad2a927d3d1e661f8
parenta8ebc7bceb104fa5e1ef1ce116d3fd85f2081af2
IB/mthca: Use mmiowb() to avoid firmware commands getting jumbled up

Upstream as 76d7cc0345a037e8eea426f8abc710abd22946dd

Firmware commands are sent to the HCA by writing multiple words to a
command register block.  Access to this block of registers is
serialized with a mutex.  However, on large SGI systems, problems were
seen with multiple CPUs issuing FW commands at the same time, because
the writes to the register block may be reordered within the system
interconnect and reach the HCA in a different order than they were
issued (even with the mutex).  Fix this by adding an mmiowb() before
dropping the mutex.

Tested-by: Arthur Kepner <akepner@sgi.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/infiniband/hw/mthca/mthca_cmd.c